Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip failing urlib3 ASM test #11861

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 6, 2025

  • There seems to be a bug in the ASM Standalone logic where the _dd.p.appsec tag is not being set on urllib3 spans. Since this tag is not set, x-datadog distributed tracing headers are not generated.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 6, 2025

CODEOWNERS have been resolved as:

tests/contrib/urllib3/test_urllib3.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python

@pr-commenter
Copy link

pr-commenter bot commented Jan 6, 2025

Benchmarks

Benchmark execution time: 2025-01-08 17:45:07

Comparing candidate commit 75a8af1 in PR branch munir/fix-asm-urlib3-test with baseline commit a225334 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@mabdinur mabdinur force-pushed the munir/fix-asm-urlib3-test branch from 2e7892d to 040dcca Compare January 6, 2025 21:56
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 6, 2025

Datadog Report

Branch report: munir/fix-asm-urlib3-test
Commit report: 75a8af1
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 52.6s Total duration (35m 24.54s time saved)

@mabdinur mabdinur changed the title chore: fix urlib asm test chore: skip failing urlib3 ASM test Jan 6, 2025
@mabdinur mabdinur marked this pull request as ready for review January 6, 2025 22:27
@mabdinur mabdinur requested review from a team as code owners January 6, 2025 22:27
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 7, 2025
@mabdinur mabdinur requested a review from gnufede January 7, 2025 18:49
@emmettbutler emmettbutler enabled auto-merge (squash) January 8, 2025 16:59
@emmettbutler emmettbutler merged commit 86a367a into main Jan 8, 2025
237 of 239 checks passed
@emmettbutler emmettbutler deleted the munir/fix-asm-urlib3-test branch January 8, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants